[TNT-272][TNT-275] ViewModel 내 Context 제거 및 약관 링크 수정 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- context 대신 이미지 파일 전달
SeonJeongk
changed the title
hoyahozz
requested changes
Apr 10, 2025
Comment on lines
+4
to
+5
| const val PRIVACY_POLICY_URL = "https://ymkim97.notion.site/1bcd727836a3813e9f5dd60ed9620612" | ||
| const val TERMS_OF_SERVICE_URL = "https://ymkim97.notion.site/1bcd727836a381c08c7bdf4d70c3639b" |
| val state by viewModel.uiState.collectAsStateWithLifecycle() | ||
| val dateFormatter = remember { DateFormatter() } | ||
|
|
||
| var imageFile by rememberSaveable { mutableStateOf<File?>(null) } |
Member
There was a problem hiding this comment.
이미지가 선택될 때마다 File 형태로 만들어야 할까요 ?_?
저장 시, 즉 한 번만 File 형태로 만드는건 어떨까요?
Contributor
Author
There was a problem hiding this comment.
파일 변환 시 걸리는 시간을 고려해 미리 변환해둔건데, 다시 생각해보니 굳이 그럴 필요는 없을 것 같네요..!
저장 버튼 클릭 시, File 형태로 만들도록 수정하겠습니다!
Comment on lines
51
to
59
| LaunchedEffect(completeState.value) { | ||
| if (completeState.value) { | ||
| val imageFile = withContext(Dispatchers.IO) { | ||
| state.image?.convertToAllowedImageFormat(context) | ||
| } | ||
| onNextClick(imageFile) | ||
| completeState.value = false | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
completeState 라는 중간 다리를 한 번 더 거쳐야 할까? 라는 생각이 쬐끔 드네요!
rememberCoroutineScope 를 활용해 onClick 발생 시 파일로 바로 변환 후 넘겨주는 방식은 어떨까요?_?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
식단 기록,회원 가입취소와확인버튼의 동작이 반대로 매핑되어있는 문제를 발견해 수정했습니다.📸 실행 화면
약관
default.mp4
트레이너 회원가입
default.mp4
트레이니 회원가입
default.mp4
식단 기록
default.mp4
🙆🏻 리뷰 요청 사항
👀 레퍼런스